Messages in this thread | | | Date | Mon, 22 Aug 2011 17:10:14 -0700 | From | Andi Kleen <> | Subject | Re: [PATCH 4/7] VFS: Add generic_file_llseek_size |
| |
> I think your commit comment is incorrect. It should read: > > Add a generic_file_llseek_size() variant to the VFS that allows passing > in the maximum file size, instead of always using inode->i_sb->s_maxbytes. > This can be used to eliminate some cut'n'paste seek code in ext4. > > Also, the function prototype in fs.h should take "loff_t maxbytes" instead > of "loff_t size".
Yes you're right. Will fix.
Thanks for the review.
-Andi
| |