lkml.org 
[lkml]   [2011]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] x86, mm: start mmap allocation for libs from low addresses
    On 08/22/2011 03:17 AM, Vasiliy Kulikov wrote:
    > Hi Ingo, Peter, Thomas,
    >
    > On Tue, Aug 16, 2011 at 13:05 +0400, Vasiliy Kulikov wrote:
    >> As the changes are not intrusive, we'd want to see this feature in the
    >> upstream kernel. If you know why the patch cannot be a part of the
    >> upstream kernel - please tell me, I'll try to address the issues.
    >
    > Any comments on the RFC? Otherwise, may I resend it as a PATCH for
    > inclusion?
    >
    > Thanks!

    Conceptually:

    I also have to admit to being somewhat skeptical to the concept on a
    littleendian architecture like x86.

    Code-wise:

    The code is horrific; it is full of open-coded magic numbers; it also
    puts a function called arch_get_unmapped_exec_area() in a generic file,
    which could best be described as "WTF" -- the arch_ prefix we use
    specifically to denote a per-architecture hook function.

    As such, your claim that the changes are not intrusive is plain false.

    -hpa


    \
     
     \ /
      Last update: 2011-08-22 19:29    [W:0.020 / U:31.576 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site