lkml.org 
[lkml]   [2011]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the just-initialized value
    On Mon, 22 Aug 2011, Larry Finger wrote:

    > On 08/22/2011 09:00 AM, Julia Lawall wrote:
    > > From: Julia Lawall<julia@diku.dk>
    > >
    > > Test the just-initialized value rather than some other one.
    > >
    > > The semantic match that finds this problem is as follows:
    > > (http://coccinelle.lip6.fr/)
    > >
    > > //<smpl>
    > > @r@
    > > identifier x,y,f!={PTR_ERR,ERR_PTR,ERR_CAST};
    > > statement S;
    > > @@
    > >
    > > x = f(...);
    > > (
    > > if (\(x == NULL\|IS_ERR(x)\)) S
    > > |
    > > *if (\(y == NULL\|IS_ERR(y)\))
    > > { ... when != x
    > > return ...; }
    > > )
    > > //</smpl>
    > >
    > > Signed-off-by: Julia Lawall<julia@diku.dk>
    > >
    > > ---
    > > drivers/net/wireless/mwifiex/scan.c | 2 +-
    > > 1 file changed, 1 insertion(+), 1 deletion(-)
    > >
    > > diff --git a/drivers/net/wireless/mwifiex/scan.c
    > > b/drivers/net/wireless/mwifiex/scan.c
    > > index b28241c..d3111c9 100644
    > > --- a/drivers/net/wireless/mwifiex/scan.c
    > > +++ b/drivers/net/wireless/mwifiex/scan.c
    > > @@ -1480,7 +1480,7 @@ mwifiex_update_curr_bss_params(struct mwifiex_private
    > > *priv,
    > > return -ENOMEM;
    > > }
    > > beacon_ie = kzalloc(ie_len, GFP_KERNEL);
    > > - if (!bss_desc) {
    > > + if (!beacon_ie) {
    > > dev_err(priv->adapter->dev, " failed to alloc bss_desc\n");
    > > return -ENOMEM;
    > > }
    >
    > The error message should also get the bss_desc => beacon_ie chang.

    Thanks. Pierre Louis Aublin made the same observation and I resumitted
    the patch.

    julia


    \
     
     \ /
      Last update: 2011-08-22 17:31    [W:5.312 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site