lkml.org 
[lkml]   [2011]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] coredump: fix pipe coredump when core limit is 0
    From
    Concur.  The comment should be changed
    Neil

    Oleg Nesterov <oleg@redhat.com> wrote:

    >On 08/21, Oleg Nesterov wrote:
    >>
    >> On 08/21, bookjovi@gmail.com wrote:
    >> >
    >> > For non-pipe case, limit 0 also means drop the coredump, so just put
    >> > the zero limit check at do_coredump function begining.
    >>
    >> Neil, what do you think? Should we change the code or the comment?
    >
    >Personally I think we should fix the comment. I think RLIMIT_CORE
    >doesn't apply in this case, limit == 1 check is very special. And
    >this is what linux always did, except between 725eae32 and 898b374a.
    >
    >
    >Oleg.
    >
    >
    \
     
     \ /
      Last update: 2011-08-22 00:39    [W:0.019 / U:3.052 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site