Messages in this thread | | | Date | Sun, 21 Aug 2011 17:57:56 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH] coredump: fix pipe coredump when core limit is 0 |
| |
On 08/21, Oleg Nesterov wrote: > > On 08/21, bookjovi@gmail.com wrote: > > > > For non-pipe case, limit 0 also means drop the coredump, so just put > > the zero limit check at do_coredump function begining. > > Neil, what do you think? Should we change the code or the comment?
Personally I think we should fix the comment. I think RLIMIT_CORE doesn't apply in this case, limit == 1 check is very special. And this is what linux always did, except between 725eae32 and 898b374a.
Oleg.
| |