[lkml]   [2011]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] Fix missing 'cnt' in ?: in dmatest
    On the latest tree my compiler has started giving the warning:

    drivers/dma/dmatest.c:575:28: warning: the omitted middle operand in ?: will always be ?true?, suggest explicit middle operand [-Wparentheses]

    The following patch fixes the missing middle clause with the same
    fix that Nicolas Ferre used in the similar clauses.
    (There seems to have been a race between him fixing that and
    the extra clause going in a little later).

    I don't actually know the dmatest code/structures, nor do I own
    any hardware to test it on (assuming it needs a DMA engine);
    but this patch builds, the existing code is almost certainly
    wrong and the fix is the same as the corresponding lines above it.

    (WTH is x=y?:z legal C anyway?)

    Signed-off-by: Dr. David Alan Gilbert <>

    diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
    index 765f5ff..1b0ec9d 100644
    --- a/drivers/dma/dmatest.c
    +++ b/drivers/dma/dmatest.c
    @@ -572,7 +572,7 @@ static int dmatest_add_channel(struct dma_chan *chan)
    if (dma_has_cap(DMA_PQ, dma_dev->cap_mask)) {
    cnt = dmatest_add_threads(dtc, DMA_PQ);
    - thread_count += cnt > 0 ?: 0;
    + thread_count += cnt > 0 ? cnt : 0;

    pr_info("dmatest: Started %u threads using %s\n",
    -----Open up your eyes, open up your mind, open up your code -------
    / Dr. David Alan Gilbert | Running GNU/Linux | Happy \
    \ gro.gilbert @ | | In Hex /
    \ _________________________|_____ |_______/

     \ /
      Last update: 2011-08-21 02:53    [W:0.021 / U:0.284 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site