Messages in this thread Patch in this message | | | From | Julia Lawall <> | Subject | [PATCH 5/11] kernel/sysctl.c: trivial: use BUG_ON | Date | Tue, 2 Aug 2011 12:34:58 +0200 |
| |
From: Julia Lawall <julia@diku.dk>
Use BUG_ON(x) rather than if(x) BUG();
The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ identifier x; @@ -if (x) BUG(); +BUG_ON(x);
@@ identifier x; @@ -if (!x) BUG(); +BUG_ON(!x); // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- kernel/sysctl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff -u -p a/kernel/sysctl.c b/kernel/sysctl.c --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -1600,8 +1600,7 @@ void sysctl_head_put(struct ctl_table_he struct ctl_table_header *sysctl_head_grab(struct ctl_table_header *head) { - if (!head) - BUG(); + BUG_ON(!head); spin_lock(&sysctl_lock); if (!use_table(head)) head = ERR_PTR(-ENOENT);
| |