lkml.org 
[lkml]   [2011]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 21/43] OpenRISC: No need to reset handler if SA_ONESHOT
    Date
    From: Matt Fleming <matt.fleming@intel.com>

    get_signal_to_deliver() already resets the signal handler if
    SA_ONESHOT is set in ka->sa.sa_flags, there's no need to do it again
    in handle_signal(). Furthermore, because we were modifying
    ka->sa.sa_handler (which is a copy of sighand->action[]) instead of
    sighand->action[] the original code actually had no effect on signal
    delivery.

    Acked-by: Oleg Nesterov <oleg@redhat.com>
    Cc: Jonas Bonn <jonas@southpole.se>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Matt Fleming <matt.fleming@intel.com>
    ---
    arch/openrisc/kernel/signal.c | 3 ---
    1 files changed, 0 insertions(+), 3 deletions(-)

    diff --git a/arch/openrisc/kernel/signal.c b/arch/openrisc/kernel/signal.c
    index c023db9..2f75e74 100644
    --- a/arch/openrisc/kernel/signal.c
    +++ b/arch/openrisc/kernel/signal.c
    @@ -267,9 +267,6 @@ handle_signal(unsigned long sig,
    {
    setup_rt_frame(sig, ka, info, oldset, regs);

    - if (ka->sa.sa_flags & SA_ONESHOT)
    - ka->sa.sa_handler = SIG_DFL;
    -
    spin_lock_irq(&current->sighand->siglock);
    sigorsets(&current->blocked, &current->blocked, &ka->sa.sa_mask);
    if (!(ka->sa.sa_flags & SA_NODEFER))
    --
    1.7.4.4


    \
     
     \ /
      Last update: 2011-08-19 18:51    [W:0.022 / U:121.972 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site