lkml.org 
[lkml]   [2011]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 07/43] blackfin: Use set_current_blocked() and block_sigmask()
    Date
    From: Matt Fleming <matt.fleming@linux.intel.com>

    As described in e6fa16ab ("signal: sigprocmask() should do
    retarget_shared_pending()") the modification of current->blocked is
    incorrect as we need to check whether the signal we're about to block
    is pending in the shared queue.

    Also, use the new helper function block_sigmask() which centralises
    the code for updating current->blocked after successfully delivering a
    signal and reduces the amount of duplicate code across
    architectures. In the past some architectures got this code wrong, so
    using this helper function should stop that from happening again.

    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Mike Frysinger <vapier@gentoo.org>
    Signed-off-by: Matt Fleming <matt.fleming@linux.intel.com>
    ---

    v2 of this patch depends on "[PATCH 01/43] signal: Add block_sigmask()
    for adding sigmask to current->blocked" so they need to go through the
    same tree but this patch would benefit from some maintainer ACK's.

    arch/blackfin/kernel/signal.c | 17 ++++-------------
    1 files changed, 4 insertions(+), 13 deletions(-)

    diff --git a/arch/blackfin/kernel/signal.c b/arch/blackfin/kernel/signal.c
    index d536f35..05ece02 100644
    --- a/arch/blackfin/kernel/signal.c
    +++ b/arch/blackfin/kernel/signal.c
    @@ -99,10 +99,7 @@ asmlinkage int do_rt_sigreturn(unsigned long __unused)
    goto badframe;

    sigdelsetmask(&set, ~_BLOCKABLE);
    - spin_lock_irq(&current->sighand->siglock);
    - current->blocked = set;
    - recalc_sigpending();
    - spin_unlock_irq(&current->sighand->siglock);
    + set_current_blocked(&set);

    if (rt_restore_sigcontext(regs, &frame->uc.uc_mcontext, &r0))
    goto badframe;
    @@ -266,15 +263,9 @@ handle_signal(int sig, siginfo_t *info, struct k_sigaction *ka,
    /* set up the stack frame */
    ret = setup_rt_frame(sig, ka, info, oldset, regs);

    - if (ret == 0) {
    - spin_lock_irq(&current->sighand->siglock);
    - sigorsets(&current->blocked, &current->blocked,
    - &ka->sa.sa_mask);
    - if (!(ka->sa.sa_flags & SA_NODEFER))
    - sigaddset(&current->blocked, sig);
    - recalc_sigpending();
    - spin_unlock_irq(&current->sighand->siglock);
    - }
    + if (ret == 0)
    + block_sigmask(ka, sig);
    +
    return ret;
    }

    --
    1.7.4.4


    \
     
     \ /
      Last update: 2011-08-19 18:49    [W:0.054 / U:31.040 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site