Messages in this thread | | | From | Marc Dietich <> | Subject | Re: [PATCH] Staging: nvec: Fixed various style issues. | Date | Thu, 18 Aug 2011 10:05:10 +0200 |
| |
Hey Joe,
> > On Thu, 2011-08-18 at 08:58 +0200, Marc Dietrich wrote: > > Greg, I haven't yet heard of Joe (a reviewer, see: > > http://driverdev.linuxdriverproject.org/pipermail/devel/2011-August/01921 > > 7.html) for some days now. > > I thought I was pretty clear in my reviewvand > didn't need to reply further. > > I think mixing index # and field comment in the > same style isn't very readable. > > It's your code, do what you think best.
this file certainly needs another cleanup (or maybe be moved into nvec_kbd.c). I just want to make "small" steps.
Thanks
Marc
| |