lkml.org 
[lkml]   [2011]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 3.0-git15 Atomic scheduling in pidmap_init
    On Thu, Aug 18, 2011 at 06:19:20PM -0400, Josh Boyer wrote:
    > On Thu, Aug 18, 2011 at 02:23:34PM -0700, Paul E. McKenney wrote:
    > > > > I am sorry, but I didn't make the rules! And I must carry the fix
    > > > > longer as well, if that makes you feel any better.
    > > >
    > > > bah, we're not that anal. The patch fixes a bug and prevents a nasty
    > > > warning spew. Please, send it to Linus.
    > >
    > > Given your Acked-by and Josh's Tested-by I might consider it. ;-)
    > >
    > > Speaking of which, Josh, does this patch help Nicolas and Michal?
    >
    > Yes, it did. The bug is closed because I included the patch. (I could
    > recreate it myself as well.)

    OK, good to know!

    > > > We appear to be referring to the patch "rcu: Avoid having just-onlined
    > > > CPU resched itself when RCU is idle"? If so, the changelog doesn't
    > > > even mention that the patch fixes a scheduling-while-atomic warning and
    > > > the changelog fails to refer to the redhat bug report. These omissions
    > > > should be repaired, please.
    > >
    > > OK... But I cannot bring myself to believe that my fix does more than
    > > hide some other bug. Which is OK, I will just say that in the changelog.
    >
    > I looked for this other bug myself for a while. I couldn't find it.

    Well, if there really is some other bug, it will make its continued
    presence know soon enough.

    Andrew, are you willing to ack this?

    Thanx, Paul


    \
     
     \ /
      Last update: 2011-08-19 01:19    [W:4.853 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site