[lkml]   [2011]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] checkpatch: do not test/warn of leading whitespace before signature tags
    On Wed, 2011-08-17 at 23:48 -0700, Jeff Kirsher wrote:
    > From: Bruce Allan <>
    > Commit 2011247 introduced additional style checks for signature tags in
    > patches which is good. Unfortunately, now whenever patches are checked
    > by piping the output of 'git show' or 'stg show' through checkpatch it
    > warns not to use whitespace before all signature tags since these (and the
    > rest of the patch description) are indented. Remove this test/warning.

    I think this is not a good idea.

    checkpatch is meant for patches not git log output.
    indenting signatures can cause other problems later.

    I think you can avoid this easily by using checkpatch
    option --ignore=BAD_SIGN_OFF when using git log output
    as input.

    You could also use:

    git log --format="commit %H%nAuthor: %an <%ae>%nDate: %aD%n%n%s%n%n%b"

    so that you get the current default --format=medium
    output without indenting the commit log body.

     \ /
      Last update: 2011-08-18 09:29    [W:0.019 / U:1.392 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site