lkml.org 
[lkml]   [2011]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] memcg: remove unneeded preempt_disable
    On Wed, 17 Aug 2011 23:50:53 -0700
    Greg Thelen <gthelen@google.com> wrote:

    > Both mem_cgroup_charge_statistics() and mem_cgroup_move_account() were
    > unnecessarily disabling preemption when adjusting per-cpu counters:
    > preempt_disable()
    > __this_cpu_xxx()
    > __this_cpu_yyy()
    > preempt_enable()
    >
    > This change does not disable preemption and thus CPU switch is possible
    > within these routines. This does not cause a problem because the total
    > of all cpu counters is summed when reporting stats. Now both
    > mem_cgroup_charge_statistics() and mem_cgroup_move_account() look like:
    > this_cpu_xxx()
    > this_cpu_yyy()
    >
    > Reported-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    > Signed-off-by: Greg Thelen <gthelen@google.com>

    Thank you.
    Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>



    \
     
     \ /
      Last update: 2011-08-18 09:03    [W:0.026 / U:32.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site