lkml.org 
[lkml]   [2011]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] memcg: remove unneeded preempt_disable
From
Date
On Thu, 18 Aug 2011 11:38:00 +0200, Johannes Weiner said:

> Note that on non-x86, these operations themselves actually disable and
> reenable preemption each time, so you trade a pair of add and sub on
> x86
>
> - preempt_disable()
> __this_cpu_xxx()
> __this_cpu_yyy()
> - preempt_enable()
>
> with
>
> preempt_disable()
> __this_cpu_xxx()
> + preempt_enable()
> + preempt_disable()
> __this_cpu_yyy()
> preempt_enable()
>
> everywhere else.

That would be an unexpected race condition on non-x86, if you expected _xxx and
_yyy to be done together without a preempt between them. Would take mere
mortals forever to figure that one out. :)

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-08-18 16:29    [W:0.207 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site