Messages in this thread | | | Date | Thu, 18 Aug 2011 14:58:16 +0100 | From | "Jan Beulich" <> | Subject | Re: [PATCH] i386/bigsmp: eliminate false warnings regarding logical APIC ID mismatches |
| |
>>> On 18.08.11 at 15:04, Tejun Heo <tj@kernel.org> wrote: > On Thu, Aug 18, 2011 at 01:54:44PM +0100, Jan Beulich wrote: >> Fix this (for the time being, i.e. until x86_32_early_logical_apicid() >> will get removed again, as Tehun says ought to be possible) by >> overriding the previously stored values at the point where the APIC >> driver gets overridden. > > Hmmm... how about just removing the WARN_ON() in setup_local_APIC()? > We already don't depend on the value so just overriding it isn't > dangerous at all.
I was not able to prove for myself that all of the uses of early_per_cpu(x86_cpu_to_logical_apicid, ...) are actually only possible to be hit after setup_local_APIC(), so I can't really propose a patch like this.
Jan
| |