lkml.org 
[lkml]   [2011]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: x86_32_early_logical_apicid() -> one warning per CPU on late-determined BIGSMP systems
Hello,

On Thu, Aug 18, 2011 at 12:54:10PM +0100, Jan Beulich wrote:
> >>> On 12.08.11 at 12:15, Tejun Heo <tj@kernel.org> wrote:
> > Ooh, okay, bigsmp switches apic pretty late in the init. Wouldn't it
> > be better to move that to right after dmi init regardless of this
> > problem?
>
> No, because this depends on knowing num_possible_cpus(), which
> in turn can't be done until after the firmware tables got parsed (and
> that's where the ->x86_32_early_logical_apicid() call happens).

OIC, switching apic that late seems rather nasty. Eh well... :(

> > So, yeah, please go ahead and remove it.
>
> There are quite a few references to this, and some from code that
> if I change it I would have no way of testing (Summit, ES7000, NUMAQ).
> So no, I don't think I'm in the position to do this cleanup (if it really is
> just that).
>
> So for the time being I'll put together a patch re-writing
> early_per_cpu(x86_cpu_to_logical_apicid, ...) right after overriding
> apic_default with apic_bigsmp.

Yeap, sure. We'll need less invasive for -stable anyway. I'll kill
the method afterwards.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2011-08-18 14:01    [W:0.077 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site