lkml.org 
[lkml]   [2011]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 41/41] exit: Use __set_task_blocked()
    From
    Date
    On Tue, 2011-08-16 at 20:06 +0200, Oleg Nesterov wrote:
    > On 08/11, Matt Fleming wrote:
    > >
    > > As described in e6fa16ab ("signal: sigprocmask() should do
    > > retarget_shared_pending()") the modification of current->blocked is
    > > incorrect as we need to check whether the signal we're about to block
    > > is pending in the shared queue.
    >
    > Yes. but in this case the code is correct. First of all, unblocking
    > is always fine. Also, this should be used by kthreads only, and they
    > are single-threaded.
    >
    > But there are other reasons why I don't like this change, even if we
    > ignore the fact the patched exit.c can't be compiled (__set_task_blocked
    > is not exported ;).

    OK, I've dropped this patch from the series.

    --
    Matt Fleming, Intel Open Source Technology Center



    \
     
     \ /
      Last update: 2011-08-16 23:53    [W:0.020 / U:29.776 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site