Messages in this thread | | | From | Gábor Stefanik <> | Date | Tue, 16 Aug 2011 23:40:15 +0200 | Subject | Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond. |
| |
2011/8/16 Gábor Stefanik <netrolller.3d@gmail.com>: > 2011/8/16 Pekka Enberg <penberg@kernel.org>: >> 2011/8/16 Gábor Stefanik <netrolller.3d@gmail.com>: >>>> - >>>> -//==================================== >>>> -// Internal variable for module >>>> -//==================================== >>>> +/*============================================================================ >>>> +/* wb35rx.h -- >>>> +/*============================================================================ >>> >>> I'm pretty sure this is not an accepted kernel comment style. >> >> What's the problem? I think it's OK for this particular patch. >> > > The comments are not even valid C. The only reason why they do not > break is that they are immediately followed by another, > correctly-formatted (but separate) comment.
BTW, my suggested style here is the following:
/*============================================================================ * wb35rx.h -- *============================================================================*/
> > -- > Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) >
-- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
| |