Messages in this thread |  | | | Date | Tue, 16 Aug 2011 21:44:27 +0200 | | From | Oleg Nesterov <> | | Subject | [PATCH 0/1] kthreads: allow_signal: don't play with ->blocked |
| |
On 08/16, Oleg Nesterov wrote: > > > int allow_signal(int sig) > > { > > + sigset_t blocked; > > + > > if (!valid_signal(sig) || sig < 1) > > return -EINVAL; > > > > spin_lock_irq(¤t->sighand->siglock); > > /* This is only needed for daemonize()'ed kthreads */ > > Exactly. And nowadays the daemonize()'ed kthreads should not play > with allow_signal(). > > And more, I think it is the time to kill daemonize(). Contrary to > what /bin/grep thinks, it has only one user.
No, daemonize() has no users which actually need it.
Imho we should deprecate it, it has no users after the patches I sent.
> In short: this code in allow_signal() should die.
Yes.
To clarify: this change breaks drivers/staging/rtl8712/, but I belive it is wrong and should be fixed. I have already sent the patch.
Oleg.
|  |