lkml.org 
[lkml]   [2011]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] i2c: I2C_ELEKTOR should depend on HAS_IOPORT
Date
On Tuesday 16 August 2011 21:14:42 Geert Uytterhoeven wrote:
> >> config I2C_ELEKTOR
> >> tristate "Elektor ISA card"
> >> - depends on ISA && BROKEN_ON_SMP
> >> + depends on ISA && HAS_IOPORT && BROKEN_ON_SMP
> >> select I2C_ALGOPCF
> >> help
> >> This supports the PCF8584 ISA bus I2C adapter. Say Y if you own
> >
> > How can ISA be set if HAS_IOPORT is not? This shouldn't be allowed.
>
> It's always been like that. With CONFIG_ISA, we have inb() and friends. But not
> ioport_map(), which was introduced more recently.

Right. BTW, I'd really like to change that once I've picked up and fixed the
use of inb() in 8250.c. I think we should change CONFIG_HAS_IOPORT to mean
that inb(), ioport_resource and /proc/ioports are available, while a new
CONFIG_HAS_IOPORT_MAP can then replace the current CONFIG_HAS_IOPORT symbol.

Arnd


\
 
 \ /
  Last update: 2011-08-16 21:45    [W:0.074 / U:1.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site