lkml.org 
[lkml]   [2011]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC PATCH v2 06/13] docs/dt: Document nvidia,tegra20-pinmux binding
    Date
    On Monday 15 August 2011, Stephen Warren wrote:
    > Signed-off-by: Stephen Warren <swarren@nvidia.com>
    > ---
    > .../devicetree/bindings/pinmux/pinmux_nvidia.txt | 294 ++++++++++++++++++++
    > 1 files changed, 294 insertions(+), 0 deletions(-)
    > create mode 100644 Documentation/devicetree/bindings/pinmux/pinmux_nvidia.txt
    >
    > diff --git a/Documentation/devicetree/bindings/pinmux/pinmux_nvidia.txt b/Documentation/devicetree/bindings/pinmux/pinmux_nvidia.txt
    > new file mode 100644
    > index 0000000..744e1b7
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/pinmux/pinmux_nvidia.txt
    > @@ -0,0 +1,294 @@
    > +NVIDIA Tegra 2 pinmux controller
    > +
    > +Required properties:
    > +- compatible : "nvidia,tegra20-pinmux"

    Hmm, I think it would be much better in general if we could define
    pinmux bindings in a way that is less specific to just one soc.
    The contents of this file seem to be specific to even just one
    version of the tegra chip, and might be completely different for
    tegra30 and later, right?

    Maybe Linus W can comment on this and say whether he thinks it can
    be generalized enough to apply to other pinmux drivers.

    > +Optional sub-nodes:
    > +- nvidia,mux-groups : Mux group settings; see below.
    > +- nvidia,drive-groups : Drive group settings; see below.
    > +
    > +nvidia,mux-groups sub-node:

    These concepts seem general enough to me that they can apply to
    other chips, and I would consequently drop the nvidia, prefix.

    > +Each mux pin group is represented as a sub-node of the nvidia,mux-groups node.
    > +The name of the sub-node should be the name of the mux pingroup. The following
    > +names are valid:
    > +
    > + ata
    > + atb
    > + atc
    > + atd
    > + ate
    > + cdev1
    > + cdev2
    > ...

    I noticed that each board you define has a complete list of these. Would
    it be possible to move a generic list into a tegra20-pinmux.dtsi file and
    just override the pins in the per-board .dts file that require some special
    setup?


    > +
    > +optional subnode-properties:
    > +- nvidia,pull-up : Boolean, apply Tegra's internal pull-up to the pin.
    > +- nvidia,pull-down : Boolean, apply Tegra's internal pull-down to the pin.
    > +- nvidia,tristate : Boolean, tristate the pin. Otherwise, drive it.
    > +
    > +If both nvidia,pull-up and nvidia,pull-down are specified, nvidia,pull-up
    > +takes precedence.

    These again seem generic enough to go into a general pinmux binding, without
    the nvidia, prefix.

    Arnd


    \
     
     \ /
      Last update: 2011-08-16 15:53    [W:0.023 / U:30.924 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site