lkml.org 
[lkml]   [2011]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH,v2] sparc32: unbreak arch_write_unlock()
From
From: Mikael Pettersson <mikpe@it.uu.se>
Date: Mon, 15 Aug 2011 22:11:50 +0200

> The sparc32 version of arch_write_unlock() is just a plain assignment.
> Unfortunately this allows the compiler to schedule side-effects in a
> protected region to occur after the HW-level unlock, which is broken.
> E.g., the following trivial test case gets miscompiled:
>
> #include <linux/spinlock.h>
> rwlock_t lock;
> int counter;
> void foo(void) { write_lock(&lock); ++counter; write_unlock(&lock); }
>
> Fixed by adding a compiler memory barrier to arch_write_unlock(). The
> sparc64 version combines the barrier and assignment into a single asm(),
> and implements the operation as a static inline, so that's what I did too.
>
> Compile-tested with sparc32_defconfig + CONFIG_SMP=y.
>
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>

Applied.


\
 
 \ /
  Last update: 2011-08-15 23:41    [W:0.036 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site