Messages in this thread | | | From | Stephen Warren <> | Date | Mon, 15 Aug 2011 08:47:27 -0700 | Subject | RE: [RFC PATCH 08/12] gpio/tegra: Add device tree support |
| |
Belisko Marek wrote at Saturday, August 13, 2011 3:49 AM: > On Sat, Aug 13, 2011 at 12:54 AM, Stephen Warren <swarren@nvidia.com> wrote: > > Signed-off-by: Stephen Warren <swarren@nvidia.com> > > --- > > drivers/gpio/gpio-tegra.c | 31 +++++++++++++++++++++++++++++++ > > 1 files changed, 31 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c ... > > +static void __init tegra_gpio_probe_dt(struct platform_device *pdev) > > +{ > > + const __be32 *gpios; > > + u32 gpioslen; > > + int i; > > + > > + gpios = of_get_property(pdev->dev.of_node, "nvidia,gpios", &gpioslen); > > + if (gpios == NULL) > > + return; > > + > > + gpioslen /= sizeof(*gpios); > > + for (i = 0; i < gpioslen; i++, gpios++) { > > + u32 gpio = be32_to_cpup(gpios); > > + dev_err(&pdev->dev, "Enabling GPIO %d\n", gpio); > > Is really necessary to print all enabled gpio's to console? Also seen > same in pinmux probe.
Oops, that's certainly not necessary. That was debugging code, and I meant to convert to dev_dbg before posting.
-- nvpublic
| |