lkml.org 
[lkml]   [2011]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] usb: musb: ux500: optimize DMA callback routine
Hi,

On Sun, Aug 14, 2011 at 07:50:46PM +0200, Per Forlin wrote:
> On 12 August 2011 11:41, Felipe Balbi <balbi@ti.com> wrote:
> > Hi,
> >
> > On Mon, Aug 08, 2011 at 01:01:06PM +0200, Per Forlin wrote:
> >> From: Per Forlin <per.forlin@linaro.org>
> >>
> >> Skip the use of work queue and call musb_dma_completion() directly from
> >> DMA callback context.
> >>
> >> Here follows measurements on a Snowball board with ondemand governor active.
> >>
> >> Performance using work queue:
> >> (105 MB) copied, 6.23758 s, 16.8 MB/s
> >> (105 MB) copied, 5.7151 s, 18.3 MB/s
> >> (105 MB) copied, 5.83583 s, 18.0 MB/s
> >> (105 MB) copied, 5.93611 s, 17.7 MB/s
> >>
> >> Performance without work queue
> >> (105 MB) copied, 5.62173 s, 18.7 MB/s
> >> (105 MB) copied, 5.61811 s, 18.7 MB/s
> >> (105 MB) copied, 5.57817 s, 18.8 MB/s
> >> (105 MB) copied, 5.58549 s, 18.8 MB/s
> >>
> >> Signed-off-by: Per Forlin <per.forlin@linaro.org>
> >> Acked-by: Mian Yousaf Kaukab<mian.yousaf.kaukab@stericsson.com>
> >
> > this patch doesn't apply anymore:
> >
> > $ patch -p1 --dry-run < ~/apply.diff
> > patching file drivers/usb/musb/ux500_dma.c
> > Hunk #2 FAILED at 55.
> > Hunk #3 succeeded at 325 (offset -4 lines).
> > Hunk #4 succeeded at 341 (offset -4 lines).
> > Hunk #5 succeeded at 367 (offset -4 lines).
> > 1 out of 5 hunks FAILED -- saving rejects to file drivers/usb/musb/ux500_dma.c.rej
> >
> > care to rebase on top of 3.1-rc1. Thanks
> >
> I can apply the patch on top of 3.1-rc1 but it has dependency to the
> patches I posted recently. This is the order the patches apply:
> 0001-usb-musb-ux500-set-dma-config-for-both-src-and-dst.patch
> 0002-usb-musb-ux500-replace-missing-DBG-with-dev_dbg.patch
> 0003-usb-musb-ux500-optimize-DMA-callback-routine.patch
>
> Please let me know if I should reorder the patches. I can resend all
> three in one patchset.

ok, please see if you can drop the dependency between them. $SUBJECT
isn't a fix and as such should go on next merge window.

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-08-15 13:13    [W:2.688 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site