lkml.org 
[lkml]   [2011]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: IS_ENABLED() and non-available symbols
    On 14.8.2011 19:02, Arnaud Lacombe wrote:
    > Hi,
    >
    > On Sun, Aug 14, 2011 at 12:55 PM, Arnaud Lacombe <lacombar@gmail.com> wrote:
    >> The solution is trivial, but I am not sure we want to go that way: we
    >> need to generated a __enabled_ entry for symbols for _all_ symbols in
    >> the configuration, even internal one
    >>
    > That should do the job...
    >
    > -= NOT FOR MERGE =-
    >
    > Not-Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
    >
    > ---
    > scripts/kconfig/confdata.c | 42 +++++++++++++++++++++++++++++++-----------
    > 1 files changed, 31 insertions(+), 11 deletions(-)
    >
    > for_all_symbols(i, sym) {
    > + conf_write_symbol(out_h, sym, &header__enabled_printer_cb, NULL);
    > +
    > sym_calc_value(sym);
    > if (!(sym->flags & SYMBOL_WRITE) || !sym->name)
    > continue;

    I like the approach, it will work even with not visible symbols and
    still catch typos (which #ifdef does not protect against). But with the
    patch as-is, the generated autoconf.h starts with lots of

    #define __enabled_CONFIG_(null) 1
    #define __enabled_CONFIG_(null)_MODULE 0
    #define __enabled_CONFIG_(null) 1
    #define __enabled_CONFIG_(null)_MODULE 0
    #define __enabled_CONFIG_(null) 0

    Michal


    \
     
     \ /
      Last update: 2011-08-15 12:57    [W:4.029 / U:0.768 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site