Messages in this thread | | | Subject | Re: [PATCH v3 2/4] Keep nr_dentry per super block | From | Eric Dumazet <> | Date | Sun, 14 Aug 2011 19:38:42 +0200 |
| |
Le dimanche 14 août 2011 à 19:13 +0400, Glauber Costa a écrit : > Now that we have per-sb shrinkers, it makes sense to have nr_dentries > stored per sb as well. We turn them into per-cpu counters so we can > keep acessing them without locking. > > Signed-off-by: Glauber Costa <glommer@parallels.com>
> } > diff --git a/fs/super.c b/fs/super.c > index 3f56a26..e95ac4f 100644 > --- a/fs/super.c > +++ b/fs/super.c > @@ -119,6 +119,9 @@ static struct super_block *alloc_super(struct file_system_type *type) > s = NULL; > goto out; > } > + > + percpu_counter_init(&s->s_nr_dentry, 0); > +
You should take care of possible error return at this point.
(We probably should check the percpu_counter_init() done in tcp_init(), but they are done at boot time, with nearly no chance of failure)
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |