lkml.org 
[lkml]   [2011]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ARM: zImage: Skip relinking if nothing changes
From
Hi,

On Fri, Aug 12, 2011 at 6:03 PM, Sam Ravnborg <sam@ravnborg.org> wrote:
>>
>> I suspect this would have done the job:
>>
>> $(obj)/font.o: $(srctree)/drivers/video/console/font_acorn_8x8.c
>>         $(cmd,cc_o_c)'
>
> I prefer using $(call,shipped) and let kbuild figure out how
> build an .o file from a .c file.
>
> In other words - avoiding use of the internal to Makefile.build
> variables in various places.
>
indeed, but I'd argue that 1) this would not be the first Makefile
using these internal macros (alpha and ia64 are using such construct
for aliasing) and 2) the `cmd_shipped' stuff is as internal than other
functions :-)

I wonder if we could not make kbuild provide an interface for such code-reuse...

- Arnaud
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-08-13 00:19    [W:0.053 / U:0.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site