lkml.org 
[lkml]   [2011]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] usb: gadget: storage_common: make FSG_NUM_BUFFERS variable size
On Fri, 12 Aug 2011, Felipe Balbi wrote:

> On Mon, Aug 08, 2011 at 11:43:35PM +0200, Per Forlin wrote:
> > FSG_NUM_BUFFERS is set to 2 as default.
> > Usually 2 buffers are enough to establish a good buffering pipeline.
> > The number may be increased in order to compensate a for bursty VFS
> > behaviour.

> would it make sense to have this as a module parameter so we don't need
> to recompile the driver everytime we want to test the driver with a
> different number of buffers ??
>
> Alan ?

People generally object to new module parameters unless there's a very
good reason for them.

Since people won't want to experiment with changing this value unless
they're debugging anyway, we might make it a conditional module
parameter -- don't define the parameter unless CONFIG_USB_DEBUG is
enabled.

Alan Stern



\
 
 \ /
  Last update: 2011-08-12 17:51    [W:0.079 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site