Messages in this thread | | | Date | Thu, 11 Aug 2011 12:11:27 +0200 | From | Lars-Peter Clausen <> | Subject | Re: [PATCH 2/4] ASoC: Add ADAU1373 codec support |
| |
>> + SOC_ENUM("Lineout1 Mono Stereo", adau1373_lineout1_mode_enum), >> + SOC_ENUM("Speaker Mono Stereo", adau1373_speaker_mode_enum), > > I'd expect these to be platform data/machine data rather than user > control? The speaker wiring isn't going to vary dynamically... > You still might want to switch, for whatever particular reason, between mono and stereo at runtime.
>> + switch (freq / params_rate(params)) { >> + case 1024: /* fs */ >> + div = 0; >> + break; >> + case 1536: /* 2/3 fs */ >> + div = 1; >> + break; > > These comments look inaccuate, fs is the sample rate so a divide of 1 > would be fs.
div contains the register value representation of that particular divider.
| |