lkml.org 
[lkml]   [2011]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 2/2] Output stall data in debugfs
From
Date
On Thu, 2011-08-11 at 13:10 -0700, Alex Neronskiy wrote:
>
> Another change is to allow concurrent writers. The readers are
> serialized but the writers are concurrent; isn't that a strange
> design? The way the "main" index is changed also looks problematic. A
> writer will switch the index before anything useful is even known to
> be in the buffer, and then a reader can go ahead and get that lock and
> read something potentially very old and misleading. I don't think
> that's okay.

Ah, right, yeah, stick another lock in there.. One does worry about the
whole writer concurrency thing though, isn't it likely all cpus will
tickle the thing in quick succession? Putting a global lock in that path
isn't good,.. always think of the poor sod with the 4096 cpu machine.

Also, is all of this really useful? The hardlockup watchdog is useful
when you mess up bad, but other than that I've never found it to be
useful at all.

I mean, we're at the point where a PREEMPT=y kernel has a pretty decent
latency and the PREEMPT_RT kernels live at ~30us. So wth are you
measuring?


\
 
 \ /
  Last update: 2011-08-11 22:27    [from the cache]
©2003-2011 Jasper Spaans