Messages in this thread | | | Date | Thu, 11 Aug 2011 08:12:45 +0200 | From | Jes Sorensen <> | Subject | Re: Missing put_cpu() in arch/ia64/sn/kernel/sn2/sn_hwperf.c? |
| |
On 08/08/11 23:37, Tony Luck wrote: > On Mon, Aug 8, 2011 at 11:05 AM, Thomas Meyer <thomas@m3y3r.de> wrote: >> The function sn_hwperf_op_cpu() seems to miss a corresponding put_cpu(). >> >> Or is this done in another function? I didn't find it. > > It would be hard to do it elsewhere - this function may not have done > a get_cpu() [in the cpu == SN_HWPERF_ARG_ANY_CPU case]. > > The logic is a bit tortuous here ... perhaps simpler to split the tests > up. Does the attached patch look right?
Hi Tony,
You probably want someone from SGI to look at it, so I'll forward to Robin Holt.
I haven't been at SGI for about 2 years now :)
Cheers, Jes
| |