[lkml]   [2011]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 5/8] staging: vme: add functions for bridge module refcounting
On Wed, Aug 10, 2011 at 08:39:07 +0100, Martyn Welch wrote:
> And I think you need to go and do a grep of the code and find out where those
> functions are actually used, rather than blindly relying on the comment.
> Go grep the code.

/me greps once again..

RapidIO: there are no rapidIO drivers upstream, only switches
and rionet, which does not manage RapidIO devices (it just sends
Ethernet packets on top of RapidIO's messaging). So obviously
there aren't any callers.

PCI: pci_dev_get() referenced in 60 files. Another way of
explicitly incrementing the refcount of a pci device is with
pci_get_device(), which searches in the device list for a
particular one by its vendor/device ID. This function is
referenced in 127 files.

USB: usb_get_dev() referenced in 75 files.

There are also lots of direct calls to get_device() from .probe
methods of devices not tied to a particular bus.

Guess that was enough grepping.

> Suitable bug fixes are welcome.

I sent a fix (as part of an admittedly large patchset) in
Nov 2010[1], ie 9 months ago, you were sick at the time and
told me you'd have a look at the changes later[2], which
unfortunately never happened, even after pinging you off-list.

Anyway let's forget that, Manohar's patches are what matters now.



 \ /
  Last update: 2011-08-10 11:19    [W:0.107 / U:2.488 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site