lkml.org 
[lkml]   [2011]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5 v4] mfd: omap: usb: Runtime PM support
On Tue, Aug 09, 2011 at 07:45:09PM +0530, Keshava Munegowda wrote:
> From: Keshava Munegowda <Keshava_mgowda@ti.com>
>
> The usbhs core driver does not enable/disable the intefrace and


typo: interface

> fucntional clocks; These clocks are handled by hwmod and runtime pm,


typo: functional

> hence insted of the clock enable/disable, the runtime pm APIS are
> used. however,the port clocks are handled by the usbhs core.
>
> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com>

...
> @@ -913,12 +598,15 @@ static int usbhs_enable(struct device *dev)
> (pdata->ehci_data->reset_gpio_port[1], 1);
> }
>
> -end_count:
> - omap->count++;
> + pm_runtime_put_sync(dev);
> spin_unlock_irqrestore(&omap->lock, flags);

Is pm_runtime_irq_safe() needed (else I think runtime PM callbacks may
re-enable IRQs... or there's the new *_suspend runtime PM calls that
may avoid this)?

...
> @@ -266,10 +261,12 @@ static int ehci_hcd_omap_remove(struct platform_device *pdev)
> struct usb_hcd *hcd = dev_get_drvdata(dev);
>
> usb_remove_hcd(hcd);
> - omap_usbhs_disable(dev);
> disable_put_regulator(dev->platform_data);
> - iounmap(hcd->regs);
> usb_put_hcd(hcd);
> + iounmap(hcd->regs);


usb_put_hcd may release the hcd, needs to be after the deref for
iounmap.

> + pm_runtime_put_sync(dev);
> + pm_runtime_disable(dev);


Todd


\
 
 \ /
  Last update: 2011-08-10 18:35    [W:0.347 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site