lkml.org 
[lkml]   [2011]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sunrpc: use better NUMA affinities
On Sat, Jul 30, 2011 at 09:30:25AM +1000, NeilBrown wrote:
> On Sat, 30 Jul 2011 06:34:44 +1000 Greg Banks <gnb@fastmail.fm> wrote:
> > The "killall nfsd" semantics in those scripts are awful and lead to
> > problems shutting down when there are lots of threads. It would
> > probably be an improvement to provide a better shutdown mechanism and
> > force distros to use it.
>
> rpc.nfsd 0
>
> will stop all nfsd threads. Follow with
>
> exportfs -f
>
> and you should be done. I'm not 100% sure about the nfsv4 thread though -
> would need to check.
>
> And yes - I would love it if distros could standardise on start/stop scripts
> so upstreams could maintain them sensibly. This is my personal number 1
> reason for liking systemd - it pushes for this standardisation.

I can't remember if this is getting fixed in Fedora--probably not. We
should fix it.

I'd also be fine with logging a deprecation message when someone signals
an nfsd thread.

> > Or, you could preserve the effective semantics by having a single
> > "nfsd" thread whose purpose is to notice that it's being signalled and
> > perform a clean shutdown (perhaps blocking the thread doing the kill()
> > call until the shutdown has completed).
>
> That's kinda neat. It would be an ugly wart to have to keep around, but
> sometimes that the price we pay for "no regressions".

Yep; patch welcomed.

--b.


\
 
 \ /
  Last update: 2011-08-02 03:09    [W:0.735 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site