Messages in this thread Patch in this message |  | | | Date | Mon, 01 Aug 2011 16:18:36 -0700 | | From | Greg KH <> | | Subject | [21/70] firewire: ohci: do not bind to Pinnacle cards, avert panic |
| |
2.6.39-stable review patch. If anyone has any objections, please let us know.
------------------ From: Stefan Richter <stefanr@s5r6.in-berlin.de>
commit 7f7e37115a8b6724f26d0637a04e1d35e3c59717 upstream.
When firewire-ohci is bound to a Pinnacle MovieBoard, eventually a "Register access failure" is logged and an interrupt storm or a kernel panic happens. https://bugzilla.kernel.org/show_bug.cgi?id=36622
Until this is sorted out (if that is going to succeed at all), let's just prevent firewire-ohci from touching these devices.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/firewire/ohci.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -264,6 +264,7 @@ static char ohci_driver_name[] = KBUILD_ #define PCI_DEVICE_ID_AGERE_FW643 0x5901 #define PCI_DEVICE_ID_JMICRON_JMB38X_FW 0x2380 #define PCI_DEVICE_ID_TI_TSB12LV22 0x8009 +#define PCI_VENDOR_ID_PINNACLE_SYSTEMS 0x11bd #define QUIRK_CYCLE_TIMER 1 #define QUIRK_RESET_PACKET 2 @@ -3170,6 +3171,11 @@ static int __devinit pci_probe(struct pc int i, err; size_t size; + if (dev->vendor == PCI_VENDOR_ID_PINNACLE_SYSTEMS) { + dev_err(&dev->dev, "Pinnacle MovieBoard is not yet supported\n"); + return -ENOSYS; + } + ohci = kzalloc(sizeof(*ohci), GFP_KERNEL); if (ohci == NULL) { err = -ENOMEM;
|  |