lkml.org 
[lkml]   [2011]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] oprofile, x86: Convert memory allocation to static array
On Mon, Aug 01, 2011 at 11:31:42PM +0200, Robert Richter wrote:
> On 01.08.11 11:08:59, Maarten Lankhorst wrote:
> > On -rt, allocators don't work from atomic context any more,
> > and the maximum size of the array is known at compile time.
> >
> > Signed-off-by: Maarten Lankhorst <m.b.lankhorst@gmail.com>
>
> Applied to oprofile/core. Thanks, Maarten.

And what happens when the CPU reports more than 32 counters?
You have a silent buffer overflow then.

Besides I bet there are other cases like this all over the tree.

And the whole thing is tasteless.

Nacked-by: Andi Kleen <ak@linux.intel.com>

-Andi



\
 
 \ /
  Last update: 2011-08-01 23:43    [from the cache]
©2003-2011 Jasper Spaans