lkml.org 
[lkml]   [2011]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/7] perf, x86: Implement 64 bit counter support for IBS
    On 29.07.11 13:01:03, Peter Zijlstra wrote:
    > On Thu, 2011-07-28 at 15:46 +0200, Robert Richter wrote:
    > > The functions perf_event_set_period() and perf_event_try_update() can
    > > be used as generic functions. They can replace similar code that is
    > > duplicate across architectures.
    >
    > We could perhaps place them in kernel/events/pmu-lib.c or so, a place to
    > gather useful common code to pmu driver implementations.

    As we already have kernel/events/core.c I suggest to put it into
    .../common.c?

    I planned to factor this out of current perf code for x86 and maybe
    other architectures. Want to send separate patches independent from
    ibs.

    Should I add both functions already to the new file? Maybe this has
    some implications to header and makefiles.

    -Robert

    --
    Advanced Micro Devices, Inc.
    Operating System Research Center



    \
     
     \ /
      Last update: 2011-08-01 08:15    [W:0.030 / U:125.628 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site