Messages in this thread |  | | | Subject | Re: [PATCH] Fix a argument WARN bug of scripts/checkpatch.pl | | From | Joe Perches <> | | Date | Mon, 01 Aug 2011 08:15:04 -0700 |
| |
On Mon, 2011-08-01 at 20:09 +0800, Hui Zhu wrote: > Ping
Please send the original patch again to Andrew Morton <akpm@linux-foundation.org>
Acked-by: Joe Perches <joe@perches.com>
> Thanks, > Hui > > On Thu, Jul 28, 2011 at 15:14, gmail <teawater@gmail.com> wrote: > > Sorry the prev patch have the format error. So I re-send it. > > > > Get following error with a patch that have min_t error: > > Use of uninitialized value in concatenation (.) or string at > > scripts/checkpatch.pl line 1256. > > WARNING: > > This is because: > > } > > WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr); > > It lost the first argument. > > So make a patch to fix it. > > Signed-off-by: Hui Zhu <teawater@gmail.com> > > --- > > scripts/checkpatch.pl | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- a/scripts/checkpatch.pl > > +++ b/scripts/checkpatch.pl > > @@ -2574,7 +2574,8 @@ sub process { > > } else { > > $cast = $cast2; > > } > > - WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr); > > + WARN("MINMAX", > > + "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr); > > } > > }
|  |