lkml.org 
[lkml]   [2011]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/8] staging: vme: allow explicit assignment of bus numbers
    On Mon, Aug 01, 2011 at 02:10:00PM +0300, Dan Carpenter wrote:
    > On Mon, Aug 01, 2011 at 12:20:47PM +0200, Manohar Vanga wrote:
    > > -static int vme_alloc_bus_num(void)
    > > +/* call with vme_bus_num_mtx held */
    >
    > Why move the lock outside the function?
    >
    > > +static int __vme_alloc_bus_num(int bus_num)
    > > {
    >
    > regards,
    > dan carpenter
    >

    It just makes the code in __vme_add_bus cleaner when you have failures.
    I can merge __vme_add_bus and __vme_alloc_bus_num into one.

    --
    /manohar


    \
     
     \ /
      Last update: 2011-08-01 14:17    [W:0.020 / U:0.552 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site