Messages in this thread |  | | | Date | Mon, 1 Aug 2011 13:27:52 +0200 | | Subject | Re: [PATCH] Remove remaining references of CONFIG_GENERIC_TIME | | From | Geert Uytterhoeven <> |
| |
On Mon, Aug 1, 2011 at 12:14, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > On Mon, Aug 01, 2011 at 12:09:02PM +0200, Geert Uytterhoeven wrote: >> On Mon, Aug 1, 2011 at 10:36, Russell King - ARM Linux >> <linux@arm.linux.org.uk> wrote: >> > On Sat, Jul 30, 2011 at 06:14:38PM +0200, Zoltan Devai wrote: >> >> Commit 592913ecb87a9e06f98ddb55b298f1a66bf94c6b has killed off any >> >> use of this config option long ago. >> > >> > I don't see the point of this - we were free of GENERIC_TIME on ARM >> > shortly after it was originally killed off. The problem is you can't >> > stop people introducing new uses of this - because it existed once and >> > there's nothing which errors out on its presence, people are going to >> > continue submitting patches with it in. And it's going to continue >> > being missed at the review stage. >> > >> > I've a similar problem with folk on ARM including mach/gpio.h as their >> > sole gpio header file rather than linux/gpio.h - I've been trying for >> > the last 1-2 years to educate people to use linux/ in preference. You >> > can't do it, and I'm still just about the only one who picks up on that. >> > (SoC maintainers don't care.) They will end up caring when I push a >> > change during the next merge window though, so I'll eventually stop >> > mach/gpio.h being included. (Instead, it'll be asm/gpio.h). >> > >> > GENERIC_TIME though... I don't think you'll ever stop new uses of it >> > creeping in unless you can arrange for something to error out. >> >> Doesn't kconf error out when trying to select a non-existent symbol? > > Nope.
You're right. So that's a bug.
Gr{oetje,eeting}s, Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |