| | Date | Mon, 1 Aug 2011 14:10:50 +0300 | | From | Dan Carpenter <> | | Subject | Re: [PATCH 3/8] staging: vme: make [alloc|free]_consistent bridge specific |
| |
On Mon, Aug 01, 2011 at 12:20:48PM +0200, Manohar Vanga wrote: > if (bridge->parent == NULL) { > printk(KERN_ERR "Dev entry NULL\n");
The user wouldn't know which driver is printing the error.
> return NULL; > } > - pdev = container_of(bridge->parent, struct pci_dev, dev); > > - return pci_alloc_consistent(pdev, size, dma); > + if (bridge->alloc_consistent == NULL) { > + printk(KERN_ERR "alloc_consistent not supported by bridge\n");
Could probably be improved as well.
> + return NULL; > + } > +
regards, dan carpenter
|