lkml.org 
[lkml]   [2011]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/8] staging: vme: make [alloc|free]_consistent bridge specific
    On Mon, Aug 01, 2011 at 12:20:48PM +0200, Manohar Vanga wrote:
    > if (bridge->parent == NULL) {
    > printk(KERN_ERR "Dev entry NULL\n");

    The user wouldn't know which driver is printing the error.

    > return NULL;
    > }
    > - pdev = container_of(bridge->parent, struct pci_dev, dev);
    >
    > - return pci_alloc_consistent(pdev, size, dma);
    > + if (bridge->alloc_consistent == NULL) {
    > + printk(KERN_ERR "alloc_consistent not supported by bridge\n");

    Could probably be improved as well.

    > + return NULL;
    > + }
    > +

    regards,
    dan carpenter


    \
     
     \ /
      Last update: 2011-08-01 13:15    [W:0.021 / U:31.680 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site