Messages in this thread Patch in this message |  | | | From | Julia Lawall <> | | Subject | [PATCH] fs/ocfs2/dlm/dlmlock.c: free kmem_cache_zalloc'd data using kmem_cache_free | | Date | Sat, 9 Jul 2011 18:04:39 +0200 |
| |
From: Julia Lawall <julia@diku.dk>
Memory allocated using kmem_cache_zalloc should be freed using kmem_cache_free, not kfree.
The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression x,e,e1,e2; @@
x = kmem_cache_zalloc(e1,e2) ... when != x = e ?-kfree(x) +kmem_cache_free(e1,x) // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- fs/ocfs2/dlm/dlmlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/fs/ocfs2/dlm/dlmlock.c b/fs/ocfs2/dlm/dlmlock.c --- a/fs/ocfs2/dlm/dlmlock.c +++ b/fs/ocfs2/dlm/dlmlock.c @@ -440,7 +440,7 @@ struct dlm_lock * dlm_new_lock(int type, /* zero memory only if kernel-allocated */ lksb = kzalloc(sizeof(*lksb), GFP_NOFS); if (!lksb) { - kfree(lock); + kmem_cache_free(dlm_lock_cache, lock); return NULL; } kernel_allocated = 1;
|  |