lkml.org 
[lkml]   [2011]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[101/107] ipv4: fix multicast losses
    2.6.39-stable review patch.  If anyone has any objections, please let us know.

    ------------------


    From: Eric Dumazet <eric.dumazet@gmail.com>

    [ Upstream commit 9aa3c94ce59066f545521033007abb6441706068 ]

    Knut Tidemann found that first packet of a multicast flow was not
    correctly received, and bisected the regression to commit b23dd4fe42b4
    (Make output route lookup return rtable directly.)

    Special thanks to Knut, who provided a very nice bug report, including
    sample programs to demonstrate the bug.

    Reported-and-bisectedby: Knut Tidemann <knut.andre.tidemann@jotron.com>
    Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    net/ipv4/route.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    --- a/net/ipv4/route.c
    +++ b/net/ipv4/route.c
    @@ -1914,9 +1914,7 @@ static int ip_route_input_mc(struct sk_b

    hash = rt_hash(daddr, saddr, dev->ifindex, rt_genid(dev_net(dev)));
    rth = rt_intern_hash(hash, rth, skb, dev->ifindex);
    - err = 0;
    - if (IS_ERR(rth))
    - err = PTR_ERR(rth);
    + return IS_ERR(rth) ? PTR_ERR(rth) : 0;

    e_nobufs:
    return -ENOBUFS;



    \
     
     \ /
      Last update: 2011-07-08 07:15    [W:4.726 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site