lkml.org 
[lkml]   [2011]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 11/12] gma500: reversed test in mdfld_dbi_dsr_exit()
    Date
    From: Dan Carpenter <error27@gmail.com>

    We should only cleanup "dsr_info" if it's non-NULL obviously and not
    the other way around.

    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: Alan Cox <alan@linux.intel.com>
    ---

    drivers/staging/gma500/mdfld_dsi_dbi.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/staging/gma500/mdfld_dsi_dbi.c b/drivers/staging/gma500/mdfld_dsi_dbi.c
    index 9d2d97d..4897345 100644
    --- a/drivers/staging/gma500/mdfld_dsi_dbi.c
    +++ b/drivers/staging/gma500/mdfld_dsi_dbi.c
    @@ -642,7 +642,7 @@ void mdfld_dbi_dsr_exit(struct drm_device *dev)
    struct drm_psb_private *dev_priv = dev->dev_private;
    struct mdfld_dbi_dsr_info *dsr_info = dev_priv->dbi_dsr_info;

    - if (!dsr_info) {
    + if (dsr_info) {
    del_timer_sync(&dsr_info->dsr_timer);
    kfree(dsr_info);
    dev_priv->dbi_dsr_info = NULL;


    \
     
     \ /
      Last update: 2011-07-08 10:57    [W:0.019 / U:90.188 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site