lkml.org 
[lkml]   [2011]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 5/5] Staging: comedi: fix warning issue in unioxx5.c
    From
    I wonder if this patch improves code readability

    On Thu, Jul 7, 2011 at 11:00 AM, Ravishankar <ravishankarkm32@gmail.com> wrote:
    > From: Ravishankar <ravi.shankar@greenturtles.in>
    >
    > This is a patch to the unioxx5.c file that fixes up a  warning:line over 80 charcter found by the checkpatch.pl tool
    >
    > Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
    > ---
    >  drivers/staging/comedi/drivers/unioxx5.c |   25 ++++++++++++++++++-------
    >  1 files changed, 18 insertions(+), 7 deletions(-)
    >
    > diff --git a/drivers/staging/comedi/drivers/unioxx5.c b/drivers/staging/comedi/drivers/unioxx5.c
    > index 598884e..9b311c7 100644
    > --- a/drivers/staging/comedi/drivers/unioxx5.c
    > +++ b/drivers/staging/comedi/drivers/unioxx5.c
    > @@ -75,8 +75,13 @@ Devices: [Fastwel] UNIOxx-5 (unioxx5),
    >  /* 'private' structure for each subdevice */
    >  struct unioxx5_subd_priv {
    >        int usp_iobase;
    > -       unsigned char usp_module_type[12];      /* 12 modules. each can be 70L or 73L */
    > -       unsigned char usp_extra_data[12][4];    /* for saving previous written value for analog modules */
    > +       unsigned char usp_module_type[12];      /* 12 modules. each can be 70L
    > +                                                * or 73L
    > +                                               */
    > +       unsigned char usp_extra_data[12][4];    /* for saving previous written
    > +                                                * value for analog modules
    > +                                               */
    > +
    >        unsigned char usp_prev_wr_val[3];       /* previous written value */
    >        unsigned char usp_prev_cn_val[3];       /* previous channel value */
    >  };
    > @@ -398,7 +402,10 @@ static int __unioxx5_digital_read(struct unioxx5_subd_priv *usp,
    >        *data &= mask;
    >
    >        if (channel_offset > 1)
    > -               channel -= 2 << channel_offset; /* this operation is created for correct readed value to 0 or 1 */
    > +               channel -= 2 << channel_offset; /* this operation is created for
    > +                                                * correct readed value to
    > +                                                * 0 or 1
    > +                                               */
    >
    >        *data >>= channel;
    >        return 1;
    > @@ -444,7 +451,9 @@ static int __unioxx5_analog_write(struct unioxx5_subd_priv *usp,
    >        usp->usp_extra_data[module][i] = (unsigned char)((*data & 0xFF00) >> 8);
    >
    >        /* while(!((inb(usp->usp_iobase + 0)) & TxBE)); */
    > -       outb(module + 1, usp->usp_iobase + 5);  /* sending module number to card(1 .. 12) */
    > +       outb(module + 1, usp->usp_iobase + 5);  /* sending module number
    > +                                                * to card (1..12)
    > +                                               */
    >        outb('W', usp->usp_iobase + 6); /* sends (W)rite command to module */
    >
    >        /* sending for bytes to module(one byte per cycle iteration) */
    > @@ -475,7 +484,9 @@ static int __unioxx5_analog_read(struct unioxx5_subd_priv *usp,
    >        }
    >
    >        __unioxx5_analog_config(usp, channel);
    > -       outb(module_no + 1, usp->usp_iobase + 5);       /* sends module number to card(1 .. 12) */
    > +       outb(module_no + 1, usp->usp_iobase + 5);       /* sends module number
    > +                                                        * to card (1. .12)
    > +                                                       */
    >        outb('V', usp->usp_iobase + 6); /* sends to module (V)erify command */
    >        control = inb(usp->usp_iobase); /* get control register byte */
    >
    > --
    > 1.6.5.2
    >
    > _______________________________________________
    > devel mailing list
    > devel@linuxdriverproject.org
    > http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
    >



    --
    Regards,
    Denis
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-07-07 10:31    [W:0.026 / U:3.432 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site