[lkml]   [2011]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH v3 1/3] driver core: Add ability for arch code to setup pdev_archdata

    On Jul 1, 2011, at 5:09 PM, Greg KH wrote:

    > On Thu, Jun 23, 2011 at 06:33:57AM -0500, Kumar Gala wrote:
    >> On some architectures we need to setup pdev_archdata before we add the
    >> device. Waiting til a bus_notifier is too late since we might need the
    >> pdev_archdata in the bus notifier. One example is setting up of dma_mask
    >> pointers such that it can be used in a bus_notifier.
    >> We add noop version of arch_setup_pdev_archdata() in
    >> <asm-generic/platform_device.h> and allow the arch code to override with
    >> access the full definitions of struct device, struct platform_device, and
    >> struct pdev_archdata.
    > Isn't there some way to use "weak" symbols to keep us from having to
    > create this .h file in every single arch and then if the arch wants to
    > define it, it does so?
    > That should make this patch simpler, right?
    > thanks,
    > greg k-h

    Changing to weak should be doable if we are ok with the additional function call always happening.

    - k

     \ /
      Last update: 2011-07-07 15:59    [W:0.018 / U:11.664 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site