Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH V3 3/4] ARM: mpcore_wdt: Fix WDIOC_SETOPTIONS handling | Date | Thu, 7 Jul 2011 14:45:00 +0200 |
| |
On Thursday 07 July 2011, Vitaly Kuzmichev wrote: > > According to the include/linux/watchdog.h WDIOC_SETOPTIONS is > classified as 'read from device' ioctl call: > #define WDIOC_SETOPTIONS _IOR(WATCHDOG_IOCTL_BASE, 4, int) > > However, the driver 'mpcore_wdt' performs 'copy_from_user' only if > _IOC_WRITE is set, thus the local variable 'uarg' which is used in > WDIOC_SETOPTIONS handling remains uninitialized. > > The proper way to fix this is to bind WDIOC_SETOPTIONS to _IOW, > but this will break compatibility. > So adding additional condition for performing 'copy_from_user'. > > Signed-off-by: Vitaly Kuzmichev <vkuzmichev@mvista.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
| |