lkml.org 
[lkml]   [2011]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] power: gpio-charger: Fix checking return value of request_any_context_irq
On 07/04/2011 12:04 PM, Axel Lin wrote:
> request_any_context_irq() returns a negative value on failure.
> On success, it returns either IRQC_IS_HARDIRQ or IRQC_IS_NESTED.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks

> ---
> drivers/power/gpio-charger.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/power/gpio-charger.c b/drivers/power/gpio-charger.c
> index 718f2c5..a64b885 100644
> --- a/drivers/power/gpio-charger.c
> +++ b/drivers/power/gpio-charger.c
> @@ -127,7 +127,7 @@ static int __devinit gpio_charger_probe(struct platform_device *pdev)
> ret = request_any_context_irq(irq, gpio_charger_irq,
> IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
> dev_name(&pdev->dev), charger);
> - if (ret)
> + if (ret < 0)
> dev_warn(&pdev->dev, "Failed to request irq: %d\n", ret);
> else
> gpio_charger->irq = irq;



\
 
 \ /
  Last update: 2011-07-04 12:17    [W:0.158 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site