lkml.org 
[lkml]   [2011]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] ipc: introduce shm_rmid_forced sysctl
On 07/04, Vasiliy Kulikov wrote:
>
> On Mon, Jul 04, 2011 at 17:08 +0200, Oleg Nesterov wrote:
> > On 06/22, Vasiliy Kulikov wrote:
> > >
> > > +void exit_shm(struct task_struct *task)
> > > +{
> > > + struct nsproxy *nsp = task->nsproxy;
> > > + struct ipc_namespace *ns;
> > > +
> > > + if (!nsp)
> > > + return;
> > > + ns = nsp->ipc_ns;
> > > + if (!ns || !ns->shm_rmid_forced)
> >
> > This looks confusing, imho. How it is possible that ->nsproxy or
> > ->ipc_ns is NULL?
>
> I spotted the same checking logic in other places. I don't know whether
> it is redundant, I guess it can happen when the namespace is dying.
> Probably it cannot happed inside of task do_exit(), only for extern
> observers.

No, afaics it can't happen in do_exit() until we call exit_notify().
Otherwise, for example, any dying child will OOPS in do_notify_parent().
Or please look at exit_sem()->sem_lock_check(tsk->nsproxy->ipc_ns).

Oleg.



\
 
 \ /
  Last update: 2011-07-04 17:51    [W:0.045 / U:2.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site