lkml.org 
[lkml]   [2011]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] EHCI : introduce a common ehci_setup
On Sun, 3 Jul 2011, matthieu castet wrote:

> > Instead of putting this routine in ehci-hcd.c, where it will silently
> > use up unnecessary codespace on thousands or millions of desktop
> > systems, why not put it into a new separate source file? Then the
> > SOC drivers can #include that file.
> Ok if you prefer that.
> But if we allow someday to built more than one
> SOC driver at a time (this will come for distribution doing generic arm
> kernel or case like [1]). How it will work ?

Good point.

> Also because the function is static, the compiler will remove
> it, if it is not used. So it won't use extra codespace on desktop.

Ah, I hadn't thought of that. Thanks for pointing it out. Okay, you
can add my Acked-by to this patch.

Alan Stern



\
 
 \ /
  Last update: 2011-07-04 17:49    [W:0.120 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site